Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added GitRepository object to BuildDefinition #82

Merged
merged 40 commits into from
Aug 27, 2018
Merged

added GitRepository object to BuildDefinition #82

merged 40 commits into from
Aug 27, 2018

Conversation

KaiWalter
Copy link
Contributor

@KaiWalter KaiWalter commented Aug 22, 2018

PR Summary

  • removed output of objects returned from API to avoid misleading outputs for consumers
  • added GitRepository object to BuildDefinition
  • had to add a [VSTeamProjectCache]::timestamp = -1 to VSTeamAccount constructor after experiencing blocking with New-PSDrive -Name V -PSProvider SHiPS -Root 'VSTeam#VSTeamAccount' -Verbose; Get-VSTeamBuildDefinition -ProjectName someProject

PR Checklist

KaiWalter and others added 30 commits July 26, 2018 22:14
Can navigate build defs for TFS and VSTS
@DarqueWarrior
Copy link
Collaborator

12 unit tests are broken in your PR.

@KaiWalter
Copy link
Contributor Author

aw, sorry - now I see it and will fix it

@KaiWalter KaiWalter changed the title remove obsolete output from buildDefinitions module added GitRepository object to BuildDefinition Aug 23, 2018
@KaiWalter
Copy link
Contributor Author

again a learning - no matter how good your intentions are and how insignificant a change seems: never skip the unit tests

Now unit and integration tests for build definitions work again.

The problem I was trying to solve is that with the API call for Get-VSTeamBuildDefinition a repository object is returned which is missing remoteURL - hence I thought getting my own object. I need to into this again.

@KaiWalter
Copy link
Contributor Author

@DarqueWarrior as a next step I'd like to convert Queue also to class VSTeamQueue in teamspsdrive. My end game is that I can conveniently replace/exchange/update or even add elements in a build definitions tree and then update the whole definition. Hence I think each elements needs to have a proper class so it can be instantiated by the consumer.

@DarqueWarrior DarqueWarrior merged commit cd4ddbb into MethodsAndPractices:master Aug 27, 2018
@@ -24,6 +24,10 @@ Build Definition / Process / Phases / Steps are broken down into separate object
(Get-VSTeamBuildDefinition -ProjectName MyProject -Id 42).Process.Phases[0].Steps[0]
```

<<<<<<< HEAD

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a merge issue snuck in

@DarqueWarrior
Copy link
Collaborator

Thanks, I will look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants